Forum OpenACS Development: Registering does everything, but it does not redirect to a page that says "check your mail for verification link"

After I click OK on the registration form, it directs me to a blank page that has title "Account Closed". Meanwhile, it has correctly sent the email with the verification link in it, which works fine.

When looking at the code and the parameters, they look normal, and it looks like a lot of flexibility has been built in, for example, there is a variable for where to redirect after the form is submitted, and there is a way to customize the form. Has that customization been broken? I don't remember changing the parameters having to do with registration, so I'm not quite sure what's up. Any help here?

-Jim

You're welcome; and yes I needed a fix for this myself, and I also thought it was important to keep up with the legal thing, at least in the US so that the system knows that when people sign up, they own the email address.

In answer to your question, I believe it was working in 5.7.

Other than this, when I was working on this, I wanted to get thru the code and find the problem; a lot of things confused me. Could you say more about what you did leading to you discovering what the problem was?

-Jim

PS, two issues remain:

1 when deleting a user permanently from /acs-admin/users/one, it deletes the user properly and then (I guess as redirecting?) says "You don't have permission to admin ."; admin is still logged in, as evidenced by visiting other pages, I can get to the admin-protected pages, and I still see the developer support panel.

2 (as observed by a registering user) the system sends two emails right away, the verify email and the "here's how you log in, here's how you change your passwd" email; I would have thought the second email should only be sent once the user clicks on the verify link.

Regarding the delete issue... as a test, I commented out the whole if statement (with the delete commands) in /packages/acs-admin/www/users/selece-user.tcl, and then tried to delete the user using that interface, and the result was, it came back to the /acs-admin/one page correctly -- since the to-be-deleted user still existed.

This suggests there is something wrong with the page flow: if the user is to be deleted, the return url should not point at one.tcl, instead, maybe it should go one page back, to the list of users, /acs-admin/users/complex-search with whatever parameters were originally fed to it.

-Jim

Anwering all your questions takes longer than fixing the bugs :)

Other than this, when I was working on this, I wanted to get thru the code and find the problem; a lot of things confused me. Could you say more about what you did leading to you discovering what the problem was?

Yes the code is more complicated than it probably has to be. Furthermore it has many hooks for configuration, which are probably there since there are needs for this in the wild. Restructuring will probably fix existing code.

For fixing, i did the following 3 things:

1. try to understand how the code is supposed to work (i.e. the user-notification via util_user_message)
2. try ad_returnredirect -message "hi gus!" /ds/shell from ds/shell. Since this did not show the message, it was clear that notification after registry would not work either.
3. it was a surprise, that the message still did not show up. i digged into util_user_message, found it linked to the session_id, checked, where it was reset, and this was it.

Concerning export_vars: this was a call to export_vars without listed variables for export. It "exports" nothing and can be replaced. Maybe this is a leftover from a parameterization earlier, or it was introduced via cut&paste.

Concerning combining the two message: please write a RFE into the issue tracker.

Concerning the message "no permission to admin...": maybe i can look into this the next days.

all the best
-b

(these next few messages are notes about what I found)
(Gustaf, you may find these notes helpful if you decide to dive into this stuff.)

I started with some text from the email that invites me to change my passwd, to find what in openacs uses it...

The text from the email that I used, was 'Please visit the following link to change your password now', and it turns out the only place this text is found, is in the localization catalog of the acs-subsite package.

Looking at that catalog, I found that the name of that message is "acs-subsite.email_body_Registration_password", and, the only place it's used is on line 516 of the file /packages/acs-authentication/tcl/local-procs.tcl.

Looking in that file, it's a proc that refers to that message, and that proc is named auth::local::registration::Register.

Inside that proc, is a call to the proc that sends the mail, its name is auth::password::email_password.

I'll make some notes similar to this about the email that contains the verify link.

It looks like Lars Pind was in the middle of either refactoring or else deciding what to refactor, and it looks like he wanted to move at least some of the code into the auth subsystem. Does anyone think we should try to finish what he started?

-Jim